Selena Deckelmann wrote:

> !             parse_error:
> !                     if (token == GUC_EOL || token == 0)
> !                             ereport(elevel,
> !                                             (errcode(ERRCODE_SYNTAX_ERROR),
> !                                              errmsg("syntax error in file 
> \"%s\" line %u, near end of line",
> !                                                             config_file, 
> ConfigFileLineno - 1)));

Not that this has anything to do with the patch at hand, but I remember
thinking about this sort of error message in the past.  Would it be
appropriate to move the file name and line number to an errcontext()
field?

I know somebody is going to say "but errcontext is not shown when
verbosity is set to terse", to which I say that we should fix that too.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to