Hiroshi Inoue wrote: > Magnus Hagander wrote: >> Peter Eisentraut wrote: >>> Magnus Hagander wrote: >>>> However, one question: The comment currently says it's harmless to do >>>> this on non-windows platforms. Does this still hold true? >>> Yes, the non-WIN32 code path appears to be the same, still. But the >>> ifdef WIN32 part we don't want, because that presumes something about >>> the spelling of encoding names in the local iconv library. >>> >>>> If we do keep the thing win32 only, I think we should just wrap the >>>> whole thing in #ifdef WIN32 and no longer do the codeset stuff at >>>> all on >>>> Unix - that'll make for cleaner code. >>> Yes, that would be much better. >> >> Something like this then? > > It seems OK to me.
Applied. //Magnus -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
