Teodor Sigaev wrote: >> I notice you added a fillfactor reloption in ginoptions, but does it >> really make sense? I recall removing it because the original code >> contained a comment that says "this is here because default_reloptions >> wants it, but it has no effect". > > I didn't change a recognition of fillfactor value, although GIN doesn't > use it for now.
I suggest you take StdRdOptions out of the GinOptions struct, and leave fillfactor out of ginoptions. I don't think there's much point in supporting options that don't actually do anything. If the user tries to set fillfactor for a gin index, he will get an error. Which is a good thing IMHO. -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
