Alvaro Herrera <alvhe...@commandprompt.com> writes: > This is the patch in its final form. I have included a few macros to > simplify the writing of amoptions routines.
Minor gripes: * Does initialize_reloptions() need to be exported? It seems to be only called within parseRelOptions(). It's far from clear who else should be expected to call it. * The HANDLE_ macros are dangerous as-is (dangling if/else). Need to use the usual do/while trick. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers