-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Tue, Apr 15, 2008 at 4:12 AM, Tom Lane wrote: > Alvaro Herrera writes: > > As far as the Wiki page is concerned, it would be good to make sure the > > entries have a bit more info than just a header line -- things such as > > "author", who reviewed and what did the reviewer say about it. > > We should not try to make the wiki page be a substitute for reading the > linked-to discussions. (This is one of the reasons that dropped links > in the archives, such as the month-end problem, are so nasty.) > > One idea is to make more effective use of horizontal space than we were > doing with the current wiki-page markup. I'd have no objection to > including the author's name and a status indicator if it all fit on the > same line as the patch title/link. >
When you say "horizontal space", I start thinking in terms of a table, like the ancestor of the current wiki commitfest queue, ye olde http://developer.postgresql.org/index.php/Todo:PatchStatus However, the table format doesn't provide well for brief review comments, such as we currently have for the 64bit pass-by-value patch in the May CommitFest page. Personally I think the review addenda are nice. As Tom says, it shouldn't be a replacement for actually reading the thread, but it helps to get people up to speed on the status of the patch. I think it's a useful primer for those who may be interested in looking at the patch in more detail. Anyway, take a look at http://wiki.postgresql.org/wiki/Template:Patch, and http://wiki.postgresql.org/wiki/User_talk:Direvus for an example of how it is used. This is my first stab at writing a patch queue entry template. It uses a similar structure to what's already on the CommitFest pages. To make this work, all a patch submitter needs to do is go to the relevant CommitFest page and add {{patch|||}} to the Pending Patches section. If you guys find this useful, I'd be happy to add a "review" template in a similar vein. Cheers, BJ -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) Comment: http://getfiregpg.org iD8DBQFIA6eX5YBsbHkuyV0RAkzNAKDEbtZZOyUI1olsErxgp1o39dH3VQCfcBQN b25k/nEy7qupYsthhPtU7eQ= =uu+E -----END PGP SIGNATURE----- -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
