> "Mikheev, Vadim" <[EMAIL PROTECTED]> writes: > >> Actually, I'd expect the CRC check to catch an all-zeroes page (if > >> it fails to complain, then you misimplemented the CRC), so that would > >> be the place to deal with it now. > > > I've used standard CRC32 implementation you pointed me to -:) > > But CRC is used in WAL records only. > > Oh. I thought we'd agreed that a CRC on each stored disk block would > be a good idea as well. I take it you didn't do that. No, I thought we agreed disk block CRC was way overkill. If the CRC on the WAL log checks for errors that are not checked anywhere else, then fine, but I thought disk CRC would just duplicate the I/O subsystem/disk checks. -- Bruce Momjian | http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
