Tom Lane writes:

> Ryan Kirkpatrick <[EMAIL PROTECTED]> writes:
> > INSERT INTO OID_TBL(f1) VALUES ('-1040');
> > ERROR:  oidin: error reading "-1040": value too large
>
> That's coming from a possibly-misguided error check that I put into
> oidin():
>
>       unsigned long cvt;
>       char       *endptr;
>
>       cvt = strtoul(s, &endptr, 10);
>
>       ...
>
>       /*
>        * Cope with possibility that unsigned long is wider than Oid.
>        */
>       result = (Oid) cvt;

        if (sizeof(unsigned long) > sizeof(Oid) && cvt > UINT_MAX)

>       if ((unsigned long) result != cvt)
>               elog(ERROR, "oidin: error reading \"%s\": value too large", s);
>
> On a 32-bit machine, -1040 converts to 4294966256, but on a 64-bit
> machine it converts to 2^64-1040, and the test is accordingly deciding
> that that value won't fit in an Oid.

-- 
Peter Eisentraut      [EMAIL PROTECTED]       http://yi.org/peter-e/

Reply via email to