>Thank you for your feedback.
>I might have added whitespace when I was checking the patch file.
>I attach a new patch to this mail.
Thank you for the update!

>       else if (Matches("LOCK", MatchAny, "IN", "ACCESS|ROW") ||
>-                       Matches("LOCK", "TABLE", MatchAny, "IN", "ACCESS|ROW"))
>+                       Matches("LOCK", "TABLE", MatchAny, "IN", "ACCESS|ROW") 
>||
>+                       Matches("LOCK", "ONLY", MatchAny, "IN", "ACCESS|ROW") 
>||
>+                       Matches("LOCK", "TABLE", "ONLY", MatchAny, "IN", 
>"ACCESS|ROW"))
I think this code is redundant, so I change following.
---
        else if (HeadMatches("LOCK") && TailMatches("IN", "ACCESS|ROW"))
---
I created the patch, and attached it. Do you think?

>> 2. The command "LOCK TABLE a, b;" can be executed, but tab-completion
>> doesn't work properly. Is it OK?
>It's OK for now.
>But it should be able to handle a case of multiple tables in the future.
OK. I agreed.

Regards,
Shinya Kato

Attachment: fix_tab_completion_of_lock.patch
Description: fix_tab_completion_of_lock.patch

Reply via email to