On Wed, Sep 1, 2021 at 8:43 PM Jacob Champion <pchamp...@vmware.com> wrote: > > On Wed, 2021-09-01 at 15:42 +0000, Jacob Champion wrote: > > The cfbot found a failure in postgres_fdw, which I completely neglected > > in my design. I think the desired functionality should be to allow the > > ldapuser connection option during CREATE USER MAPPING but not CREATE > > SERVER. > > Fixed in v2, attached.
A couple of quick comments from a quick look-over: I'm a bit hesitant about the ldapuser libpq parameter. Do we really want to limit ourselves to just ldap, if we allow this? I mean, why not allow say radius or pam to also specify a different username for the external system? If we want to do that, now or in the future, we should have a much more generic parameter name, something like authuser? Why do we actually need ldap_map_dn? Shouldn't this just be what happens if you specify map= on an ldap connection? -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/