> On 28 Sep 2021, at 00:55, Rachel Heaton <rachelmhea...@gmail.com> wrote:

> While developing I got this error and it was difficult to figure out what was 
> going on. 
> 
> Thanks to Jacob, I was able to learn the context of the failure, so we 
> created this small patch. 

I can see that, and I think this patch makes sense even though we don't have
much of a precedent for outputting informational messages from Makefiles.

> The text of the error message, of course, is up for debate, but hopefully 
> this will make it more clear to others. 

+       echo 'libpq must not call exit'; exit 1; \

Since it's not actually libpq which calls exit (no such patch would ever be
committed), I think it would be clearer to indicate that a library linked to is
the culprit.  How about something like "libpq must not be linked against any
library calling exit"?

--
Daniel Gustafsson               https://vmware.com/



Reply via email to