> On Sep 22, 2021, at 6:14 AM, Amul Sul <sula...@gmail.com> wrote:
>
>> Attached patch v34-0010 adds a test of cursors opened FOR UPDATE interacting
>> with a system that is set read-only by a different session. The expected
>> output is worth reviewing to see how this plays out. I don't see anything
>> in there which is obviously wrong, but some of it is a bit clunky. For
>> example, by the time the client sees an error "FATAL: WAL is now
>> prohibited", the system may already have switched back to read-write. Also,
>> it is a bit strange to get one of these errors on an attempted ROLLBACK.
>> Once again, not wrong as such, but clunky.
>>
>
> Can't we do the same in the TAP test? If the intention is only to test
> session termination when the system changes to WAL are prohibited then
> that I have added in the latest version, but that test does not
> reinitiate the same connection again, I think that is not possible
> there too.
Perhaps you can point me to a TAP test that does this in a concise fashion.
When I tried writing a TAP test for this, it was much longer than the
equivalent isolation test spec.
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company