On Wednesday, September 22, 2021 2:02 AM vignesh C <vignes...@gmail.com> wrote:
> Attached v30 patch has the fixes for the same.
Thanks for updating the patches.
I have one comment.
@@ -474,7 +707,75 @@ AlterPublication(ParseState *pstate, AlterPublicationStmt
*stmt)
...
+ if (list_length(relations))
+ {
...
+ /* remove the existing schemas from the publication */
+ PublicationDropSchemas(pubform->oid, delschemas, false);
...
+ }
After more thoughts on it, I still don't think drop all the schemas under " if
(list_length(relations))" is a good idea. I think 1) we'd better keep schema
and relation code separate. 2) if we support other type object(SEQUENCE) I the
future and only SET xx SEQUENCE, I think the above logic won't work because
both relations and schemaidlist will be NIL.
Same as the logic of drop all tables under " if (list_length(schemaidlist))".
Thoughs ?
Best regards,
Hou zj
