On 2021-Sep-18, Alexander Korotkov wrote:
> I see now. I think I'm rather favoring splitting visibilitymap.h.
Agreed, this looks sane to me. However, I think the
VM_ALL_{VISIBLE,FROZEN} macros should remain in visibilitymap.h, since
they depend on the visibilitymap_get_status function (and pg_upgrade
doesn't use them).
There's a typo "maros" for "macros" in the new header file. (Also, why
does the copyright line say "portions" if no portion under another
copyright? I think we don't say "portions" when there is only one
copyright statement line.)
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
