On Wed, Sep 15, 2021 at 8:36 AM Drouvot, Bertrand <bdrou...@amazon.com> wrote: > > Another rebase attached. > > The patch proposal to address Andre's walsender corner cases is still a dedicated commit (as i think it may be easier to discuss). >
Did one more battery of tests and everything went well... But doing some manually tests: 1. Setup master/replica (wal_level=logical, hot_standby_feedback=on, etc) 2. Initialize the master instance: "pgbench -i -s10 on master" 3. Terminal1: execute "pgbench -c20 -T 2000" 4. Terminal2: create the logical replication slot: 271480 (replica) fabrizio=# select * from pg_create_logical_replication_slot('test_logical', 'test_decoding'); -[ RECORD 1 ]----------- slot_name | test_logical lsn | 1/C7C59E0 Time: 37658.725 ms (00:37.659) 5. Terminal3: start the pg_recvlogical ~/pgsql ➜ pg_recvlogical -p 5433 -S test_logical -d fabrizio -f - --start pg_recvlogical: error: could not send replication command "START_REPLICATION SLOT "test_logical" LOGICAL 0/0": ERROR: replication slot "test_logical" is active for PID 271480 pg_recvlogical: disconnected; waiting 5 seconds to try again pg_recvlogical: error: could not send replication command "START_REPLICATION SLOT "test_logical" LOGICAL 0/0": ERROR: replication slot "test_logical" is active for PID 271480 pg_recvlogical: disconnected; waiting 5 seconds to try again pg_recvlogical: error: could not send replication command "START_REPLICATION SLOT "test_logical" LOGICAL 0/0": ERROR: replication slot "test_logical" is active for PID 271480 pg_recvlogical: disconnected; waiting 5 seconds to try again pg_recvlogical: error: could not send replication command "START_REPLICATION SLOT "test_logical" LOGICAL 0/0": ERROR: replication slot "test_logical" is active for PID 271480 pg_recvlogical: disconnected; waiting 5 seconds to try again pg_recvlogical: error: could not send replication command "START_REPLICATION SLOT "test_logical" LOGICAL 0/0": ERROR: replication slot "test_logical" is active for PID 271480 pg_recvlogical: disconnected; waiting 5 seconds to try again pg_recvlogical: error: could not send replication command "START_REPLICATION SLOT "test_logical" LOGICAL 0/0": ERROR: replication slot "test_logical" is active for PID 271480 pg_recvlogical: disconnected; waiting 5 seconds to try again pg_recvlogical: error: could not send replication command "START_REPLICATION SLOT "test_logical" LOGICAL 0/0": ERROR: replication slot "test_logical" is active for PID 271480 pg_recvlogical: disconnected; waiting 5 seconds to try again BEGIN 3767318 COMMIT 3767318 BEGIN 3767319 COMMIT 3767319 BEGIN 3767320 table public.pgbench_history: TRUNCATE: (no-flags) COMMIT 3767320 BEGIN 3767323 table public.pgbench_accounts: UPDATE: aid[integer]:398507 bid[integer]:4 abalance[integer]:-1307 filler[character]:' ' table public.pgbench_tellers: UPDATE: tid[integer]:17 bid[integer]:2 tbalance[integer]:-775356 filler[character]:null table public.pgbench_branches: UPDATE: bid[integer]:4 bbalance[integer]:1862180 filler[character]:null table public.pgbench_history: INSERT: tid[integer]:17 bid[integer]:4 aid[integer]:398507 delta[integer]:182 mtime[timestamp without time zone]:'2021-09-17 17:25:19.811239' filler[character]:null COMMIT 3767323 BEGIN 3767322 table public.pgbench_accounts: UPDATE: aid[integer]:989789 bid[integer]:10 abalance[integer]:1224 filler[character]:' ' table public.pgbench_tellers: UPDATE: tid[integer]:86 bid[integer]:9 tbalance[integer]:-283737 filler[character]:null table public.pgbench_branches: UPDATE: bid[integer]:9 bbalance[integer]:1277609 filler[character]:null table public.pgbench_history: INSERT: tid[integer]:86 bid[integer]:9 aid[integer]:989789 delta[integer]:-2934 mtime[timestamp without time zone]:'2021-09-17 17:25:19.811244' filler[character]:null COMMIT 3767322 Even with activity on primary the creation of the logical replication slot took ~38s. Can we do something related to it or should we need to clarify even more the documentation? Regards, -- Fabrízio de Royes Mello Timbira - http://www.timbira.com.br/ PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento