On 9/17/21, 10:35 AM, "Alvaro Herrera" <alvhe...@alvh.no-ip.org> wrote: > On 2021-Sep-17, Bossart, Nathan wrote: > >> On 9/17/21, 9:37 AM, "Alvaro Herrera" <alvhe...@alvh.no-ip.org> wrote: > >> > If you have some time to try your reproducers with this new proposed >> > fix, I would appreciate it. >> >> I haven't had a chance to look at the patch yet, but it appears to fix >> things with my original reproduction steps for the archive_status >> stuff [0]. > > Thank you, this is good to hear.
I gave the patch a read-through. I'm wondering if the XLOG_OVERWRITE_CONTRECORD records are actually necessary. IIUC we will set XLP_FIRST_IS_ABORTED_PARTIAL on the next page, and xlp_pageaddr on that page will already be validated in XLogReaderValidatePageHeader(). Does adding this new record also help ensure the page header is filled in and flushed to disk? Nathan
