On Thu, Sep 16, 2021 at 7:31 PM Fujii Masao <masao.fu...@oss.nttdata.com> wrote:
> Hi, > > In postgres_fdw, pgfdw_xact_callback() and pgfdw_subxact_callback() do > almost the same thing to rollback remote toplevel- and sub-transaction. > But their such rollback logics are implemented separately and > in different way. Which would decrease the readability and maintainability, > I think. So how about making the common function so that those callback > functions can just use it? Patch attached. > > Regards, > > -- > Fujii Masao > Advanced Computing Technology Center > Research and Development Headquarters > NTT DATA CORPORATION > Hi, + goto fail; /* Trouble clearing prepared statements */ The label fail can be removed. Under the above condition, entry->changing_xact_state is still true. You can directly return. Cheers
