On Tue, Sep 14, 2021 at 6:38 PM vignesh C <vignes...@gmail.com> wrote: > > I have handled this in the patch attached. >
Regarding the following function in the v28-0002 patch: +/* + * Check if the relation schema is member of the schema list. + */ +static void +RelSchemaIsMemberOfSchemaList(List *rels, List *schemaidlist, bool schemacheck) I think this function is not well named or commented, and I don't like how the "schemacheck" bool parameter determines the type of objects in the "rels" list. I would suggest you simply split this function into two separate functions, corresponding to each of the blocks of the "if-else" within the for-loop of the existing RelSchemaIsMemberOfSchemaList function. The "Is" part of the existing "RelSchemaIsMemberOfSchemaList" function name implies a boolean return value, so seems misleading. So I think the names of the two functions that I am suggesting should be "CheckXXXXNotAlreadyInPublication" or something similar. Regards, Greg Nancarrow Fujitsu Australia
