On Tue, Aug 31, 2021 at 7:39 AM houzj.f...@fujitsu.com < houzj.f...@fujitsu.com> wrote:
> From Mon, Aug 30, 2021 2:15 PM Masahiko Sawada <sawada.m...@gmail.com> > wrote: > > On Fri, Aug 27, 2021 at 3:34 PM Dilip Kumar <dilipbal...@gmail.com> > wrote: > > > > > > On Fri, Aug 27, 2021 at 10:56 AM houzj.f...@fujitsu.com < > houzj.f...@fujitsu.com> wrote: > > > > > > > > On Thu, Aug 26, 2021 2:18 PM Dilip Kumar <dilipbal...@gmail.com> > wrote: > > > > > > > > > The patch looks good to me, I have rebased 0002 atop this patch > > > > > and also done some cosmetic fixes in 0002. > > > > Thank you for updating the patch! > > > > The patch looks good to me except for the below comment: > > > > + /* Delete the subxact file, if it exist. */ > > + subxact_filename(path, subid, xid); > > + BufFileDeleteFileSet(stream_fileset, path, true); > > > > s/it exist/it exists/ > > Except for Sawada-san's comment, the v6-0002 patch looks good to me. > Thanks, I will wait for a day to see if there are any other comments on this, after that I will fix this one issue and post the updated patch. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
