Hi, On 2021-08-23 15:55:03 -0400, alvhe...@alvh.no-ip.org wrote: > On 2021-Aug-23, Bossart, Nathan wrote: > > > Ah, okay. BTW the other changes you mentioned made sense to me. > > Thanks. I've pushed this now to all live branches.
While rebasing the aio patchset ontop of HEAD I noticed that this commit added another atomic operation to XLogWrite() with archiving enabled. The WAL write path is really quite hot, and at least some of the NotifySegmentsReadyForArchive() calls are done while WALWriteLock is held. I think we should at least try to make the fast-path where no segment boundaries were crossed use no atomic operations. Greetings, Andres Freund