On Thu, Aug 26, 2021 at 4:24 PM Mark Dilger <mark.dil...@enterprisedb.com> wrote: > > On Aug 26, 2021, at 2:38 PM, Peter Geoghegan <p...@bowt.ie> wrote: > > It looks like we neglect to call CHECK_FOR_INTERRUPTS() anywhere > > inside verify_heapam.c. Is there any reason for this? > > Not any good one that I can see.
Seems that way. Want to post a patch? > > Not sure if pg_amcheck itself is a factor here too -- didn't get that far. > > That runs an event loop in the client over multiple checks (heap and/or > btree) running in backends, just as reindexdb and vacuumdb do over parallel > reindexes and vacuums running in backends. It should be just as safe to > ctrl-c out of pg_amcheck as out of those two. They all three use > fe_utils/cancel.h's setup_cancel_handler(), so I would expect modifying > verify_heapam would be enough. Right. I checked that out myself, after sending my email from earlier. We don't have any problems when pg_amcheck happens to be verifying a B-Tree index -- verify_nbtree.c already has CHECK_FOR_INTERRUPTS() at a few key points. -- Peter Geoghegan
