On Tue, 17 Aug 2021 at 19:06, 李杰(慎追) <adger...@alibaba-inc.com> wrote: > Your answer explains that we still need to ModifyTable node without Leaf > partitions. > You are right about this. > > But you can review the source code again,
I'd been looking at the code in ExecInitModifyTable() that's the same as what you pasted thinking you meant that. I think for the check for partitioned tables in ExecModifyTable() then it's likely just dead code. It seems to be causing a bit of confusion though, so might be worth doing something about. Copied in Tom to see what he thinks as it's one of his. David