On 20.07.21 13:15, Denis Hirn wrote:
In the next version of the patch, would you be so kind as to include
updated documentation of the feature and at least one regression test
of same?
As requested, this new version of the patch contains regression tests and
documentation.
The tests fail when you build with assertions enabled (configure
--enable-cassert).
Some quick style comments:
DocBook content should use 1-space indentation (not 2 spaces).
Typo?: /* we'll see this later */ -> "set"
Opening brace after "if" should be on new line. (See existing code.)
Also, there should be a space after "if".
These casts appear to be unnecessary:
if((Node *) stmt->larg != NULL && (Node *) stmt->rarg != NULL)
