On Wed, Aug 11, 2021 at 8:13 PM David Rowley <dgrowle...@gmail.com> wrote: > > On Thu, 12 Aug 2021 at 05:11, John Naylor <john.nay...@enterprisedb.com> wrote: > > 0001 moves some declarations around so that "slow" popcount functions are called directly on non-x86 platforms. > > I was wondering if there was a reason that you didn't implement this > by just changing pg_popcount32 and pg_popcount64 to be actual > functions rather than function pointers when TRY_POPCNT_FAST is not > defined? These functions would then just return > pg_popcountNN_slow(word); > > This would save from having to change all the current callers of the > functions to use the macro instead. That might be nice for any > extensions which are using these functions.
Hmm, it wasn't obvious to me that would work, but I tried it and came up with v2. Is this what you had in mind? -- John Naylor EDB: http://www.enterprisedb.com
v2-0002-Replace-intrinsics-in-pg_popcount-32-64-_slow-wit.patch
Description: Binary data
v2-0001-Use-direct-function-calls-for-pg_popcount-32-64-o.patch
Description: Binary data
