On Thu, 5 Aug 2021 at 07:02, John Naylor <john.nay...@enterprisedb.com> wrote: > > #if defined(_MSC_VER) && defined(_WIN64) > > #define HAVE_X86_64_POPCNTQ > > #endif > > That seems fine. I don't know PG can build with Arm on Windows, but for the > cpuid to work, it seems safer to also check for __x86_64?
That's a good point. I've adjusted it to do #if defined(_MSC_VER) && defined(_M_AMD64). I've attached a v2 patch which I think is more along the lines of what you had in mind. David
use_popcnt_on_msvc_v2.patch
Description: Binary data
