On Mon, Aug 2, 2021 at 12:41 PM Andres Freund <and...@anarazel.de> wrote: > - AuxiliaryProcessMain() is used for two independent tasks: Start bootstrap / > checker mode and starting auxiliary processes. In HEAD there's maybe 5 lines > out 250 that are actually common to both uses. > > A related oddity is that we reserve shared memory resources for bootstrap & > checker aux processes, despite those never existing. > > This is addressed in patches 1-7
This all looks pretty mechanical and, I would guess, not very controversial. > - The order of invocation of InitProcess()/InitAuxiliaryProcess() and > BaseInit() depends on EXEC_BACKEND. Due to that there often is no single > place initialization code can be put if it needs any locks. > > This is addressed in patches 8-9 > > - PostgresMain() has code for single user and multi user interleaved, making > it unnecessarily hard to understand what's going on. > > This is addressed in patches 10 This stuff I'd need to study more in order to have an intelligent opinion. -- Robert Haas EDB: http://www.enterprisedb.com
