On Wed, Jul 28, 2021 at 09:35:28PM -0700, David G. Johnston wrote:
> On Wed, Jul 28, 2021 at 6:52 PM Bruce Momjian <br...@momjian.us> wrote:
>
> I came up with the attached patch.
>
>
> Thank you. It is an improvement but I think more could be done here (not
> exactly sure what - though removing the "copy binaries for contrib modules
> from
> the old server" seems like a decent second step.)
Uh, I don't see that text.
> I'm not sure it really needs a parenthetical, and I personally dislike using
> "Consider" to start the sentence.
>
> "Bringing extensions up to the newest version available on the new server can
> be done later using ALTER EXTENSION UPGRADE (after ensuring the correct
> binaries are installed)."
OK, I went with this new text. There is confusion over install vs copy,
and whether this is happening at the operating system level or the SQL
level. I tried to clarify that, but I am not sure I was successful. I
also used the word "extension" since this is more common than "custom".
--
Bruce Momjian <br...@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
diff --git a/doc/src/sgml/ref/pgupgrade.sgml b/doc/src/sgml/ref/pgupgrade.sgml
index a83c63cd98..5ab7c57cd9 100644
--- a/doc/src/sgml/ref/pgupgrade.sgml
+++ b/doc/src/sgml/ref/pgupgrade.sgml
@@ -299,15 +299,17 @@ make prefix=/usr/local/pgsql.new install
</step>
<step>
- <title>Install custom shared object files</title>
+ <title>Install extension shared object files</title>
<para>
- Install any custom shared object files (or DLLs) used by the old cluster
- into the new cluster, e.g., <filename>pgcrypto.so</filename>,
- whether they are from <filename>contrib</filename>
- or some other source. Do not install the schema definitions, e.g.,
- <command>CREATE EXTENSION pgcrypto</command>, because these will be upgraded
- from the old cluster.
+ If the old cluster used extensions, whether from
+ <filename>contrib</filename> or some other source, install new
+ versions of the extension shared object files (or DLLs) into the
+ new cluster, e.g., <filename>pgcrypto.so</filename>.
+ Do not load the schema definitions, e.g.,
+ <command>CREATE EXTENSION pgcrypto</command>, because these will be
+ recreated from the old cluster. (The extensions may be
+ upgraded later using <literal>ALTER EXTENSION ... UPGRADE</literal>.)
Also, any custom full text search files (dictionary, synonym,
thesaurus, stop words) must also be copied to the new cluster.
</para>
@@ -494,10 +496,10 @@ pg_upgrade.exe
</step>
<step>
- <title>Install custom shared object files</title>
+ <title>Install extension shared object files</title>
<para>
- Install the same custom shared object files on the new standbys
+ Install the same extension shared object files on the new standbys
that you installed in the new primary cluster.
</para>
</step>
