On Mon, Jul 26, 2021 at 11:05 AM Bossart, Nathan <bossa...@amazon.com> wrote:
> Here are my suggestions in patch form.

+    printf(_("  -S, --sync-only           safely write all database
files to disk and exit\n"));

Not your patch's fault, but the word "write" does not seem to convey
the true intent of the option, because generally a "write" operation
is still limited to dirtying the OS buffers, and does not guarantee
sync-to-disk.

It'd be better if the help message said, either "flush all database
files to disk and exit",or "sync all database files to disk and exit".

Best regards,
--
Gurjeet Singh http://gurjeet.singh.im/


Reply via email to