One thing I just happened to notice is this part of your commit message : REPLICA IDENTITY columns are always replicated : irrespective of column names specification.
... for which you don't have any tests -- I mean, create a table with a certain REPLICA IDENTITY and later try to publish a set of columns that doesn't include all the columns in the replica identity, then verify that those columns are indeed published. Having said that, I'm not sure I agree with this design decision; what I think this is doing is hiding from the user the fact that they are publishing columns that they don't want to publish. I think as a user I would rather get an error in that case: ERROR: invalid column list in published set DETAIL: The set of published commands does not include all the replica identity columns. or something like that. Avoid possible nasty surprises of security- leaking nature. -- Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/ "On the other flipper, one wrong move and we're Fatal Exceptions" (T.U.X.: Term Unit X - http://www.thelinuxreview.com/TUX/)
