On Mon, Jul 12, 2021 at 5:51 PM tushar <tushar.ah...@enterprisedb.com> wrote: > > On 7/8/21 9:26 PM, Robert Haas wrote: > > Here at last is a new version. > Please refer this scenario ,where backup target using > --server-compression is closing the server > unexpectedly if we don't provide -no-manifest option > > [tushar@localhost bin]$ ./pg_basebackup --server-compression=gzip4 -t > server:/tmp/data_1 -Xnone > NOTICE: WAL archiving is not enabled; you must ensure that all required > WAL segments are copied through other means to complete the backup > pg_basebackup: error: could not read COPY data: server closed the > connection unexpectedly > This probably means the server terminated abnormally > before or while processing the request. >
I think the problem is that bbsink_gzip_end_archive() is not forwarding the end request to the next bbsink. The attached patch so fix it. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
diff --git a/src/backend/replication/basebackup_gzip.c b/src/backend/replication/basebackup_gzip.c index e9ae50a..fc11e36 100644 --- a/src/backend/replication/basebackup_gzip.c +++ b/src/backend/replication/basebackup_gzip.c @@ -259,6 +259,8 @@ bbsink_gzip_end_archive(bbsink *sink) bbsink_archive_contents(sink->bbs_next, mysink->bytes_written); mysink->bytes_written = 0; } + + bbsink_forward_end_archive(sink); } /*
