On Fri, Jul 9, 2021 at 8:20 AM Japin Li <japi...@hotmail.com> wrote: > > On Thu, 08 Jul 2021 at 18:17, Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Thu, Jul 8, 2021 at 3:43 PM Japin Li <japi...@hotmail.com> wrote: > > Please consider review v3 patch. v3-0001 adds slot_name verification in > parse_subscription_options() and comments for why we need disable subscription > where set slot_name to NONE. >
I think we back-patch this bug-fix till v10 where it was introduced and update the comments only in HEAD. So, accordingly, I moved the changes into two patches and changed the comments a bit. Can you please test the first patch in back-branches? I'll also do it separately. > v3-0002 comes from Ranier Vilela, it reduce the > overhead strlen in ReplicationSlotValidateName(). > I think this patch has nothing to do with this bug-fix, so I suggest you discuss this in a separate patch. Personally, I don't think it will help in reducing any overhead but there doesn't appear to be any harm in changing it as proposed. -- With Regards, Amit Kapila.
v4-0001-Don-t-allow-to-set-replication-slot_name-as.patch
Description: Binary data
v4-0002-Update-comments-for-AlterSubscription.patch
Description: Binary data
