On Thu, Jul 15, 2021 at 4:30 AM Euler Taveira <eu...@eulerto.com> wrote: > > On Wed, Jul 14, 2021, at 8:21 AM, Greg Nancarrow wrote: > > Some minor v19 patch review points you might consider for your next > patch version: > > Greg, thanks for another review. I agree with all of these changes. It will be > in the next patch.
Hi, here are a couple more minor review comments for the V19 patch. (The 2nd one overlaps a bit with one that Greg previously gave). ////// 1. doc/src/sgml/ref/create_publication.sgml + columns. A <literal>NULL</literal> value causes the expression to evaluate + to false; avoid using columns without not-null constraints in the + <literal>WHERE</literal> clause. The <literal>WHERE</literal> clause does + not allow functions and user-defined operators. + </para> => typo: "and user-defined operators." --> "or user-defined operators." ------ 2. src/backend/commands/publicationcmds.c - OpenTableList IsA logic IIUC the tables list can only consist of one kind of list element. Since there is no expected/permitted "mixture" of kinds then there is no need to check the IsA within the loop like v19 is doing; instead you can check only the list head element. If you want to, then you could Assert that every list element has a consistent kind as the initial kind, but maybe that is overkill too? PSA a small tmp patch to demonstrate what this comment is about. ------ Kind Regards, Peter Smith. Fujitsu Australia
v19-0001-PS-tmp-OpenTableList-IsA-logic.patch
Description: Binary data
