John Naylor <john.nay...@enterprisedb.com> writes:
> On Thu, May 27, 2021 at 6:53 PM Tom Lane <t...@sss.pgh.pa.us> wrote:
>> Attached is a rebase over a4390abec.
> Looks good to me overall, I just had a couple questions/comments:
Thanks for looking!
> isObjectPinned and isSharedObjectPinned are now thin wrappers around
> IsPinnedObject. Is keeping those functions a matter of future-proofing in
> case something needs to be handled differently someday, or reducing
> unnecessary code churn?
Yeah, it was mostly a matter of reducing code churn. We could probably
drop isSharedObjectPinned altogether, but isObjectPinned seems to have
some notational value in providing an API that takes an ObjectAddress.
> setup_depend now doesn't really need to execute any SQL (unless third-party
> forks have extra steps here?), and could be replaced with a direct call
> to StopGeneratingPinnedObjectIds. That's a bit more self-documenting, and
> that would allow shortening this comment:
Hm, I'm not following? setup_depend runs in initdb, that is on the
client side. It can't invoke backend-internal functions any other
way than via SQL, AFAICS.
regards, tom lane
