On Sat, 10 Jul 2021 at 18:09, vignesh C <vignes...@gmail.com> wrote: > > I'm planning to handle conflicting errors separately after this > current work is done, once the patch is changed to have just the valid > scenarios(removing the scenarios you have pointed out) existing > function can work as is without any changes. Thoughts?
Ah OK, that might be reasonable. Perhaps, then errorDuplicateDefElem() and errorConflictingDefElem() would be better than what I originally suggested. BTW, another case I spotted was this: copy (select 1) to stdout csv csv header; ERROR: option "format" specified more than once LINE 1: copy (select 1) to stdout csv csv header; ^ which isn't good because there is no option called "format". Regards, Dean