On Fri, Jul 9, 2021 at 6:25 AM Fujii Masao <masao.fu...@oss.nttdata.com> wrote: > The patch could not be applied cleanly because of recent commit d854720df6. > Could you rebase the patch?
Thanks. Done.
> - /* these must have a non-negative numeric value */
> + /* these must have a positive numeric value */
>
> Isn't it better to replace this with "these must have a floating point value
> greater than or equal to zero"?
Changed.
> - errmsg("%s requires a
> non-negative numeric value",
> + errmsg("\"%s\" must be a
> numeric value greater than or equal to zero",
>
> "numeric" should be "floating point"?
Changed.
> + <quote>foo must be a numeric value greater than zero</quote> or
> + <quote>foo must be a numeric value greater than or equal to zero</quote>
> + if option <quote>foo</quote> expects a numeric value
>
> Maybe this description about numeric value is redundant
> because there is already the description about integer value?
Removed.
> - /* Number of workers should be non-negative. */
>
> Isn't it better to replace this with "Number of workers should be greater
> than zero"
> rather than removing the comment?
Changed.
PSA v6 patch.
Regards,
Bharath Rupireddy.
v6-0001-Disambiguate-error-messages-that-use-non-negative.patch
Description: Binary data
