On Tue, 6 Jul 2021 at 05:03, Justin Pryzby <pry...@telsasoft.com> wrote: > > Also, if you're going to remove the initializations here, maybe you'd also > change i and j to C99 "for" declarations like "for (int i=0, j=0; ...)" > > - PartitionListValue **all_values = NULL; > - ListCell *cell; > - int i = 0; > - int ndatums = 0; > + PartitionListValue *all_values; > + int i; > + int j; > + int ndatums; > > Same in get_non_null_list_datum_count()
I tend to only get motivated to use that for new code that does not exist in back-branches. I'll maybe stop doing that when we no longer have to support the pre-C99 versions of the code. David
