Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> writes: >> << Attaching v5-0001 here again for completion >> >> I'm attaching v5-0001 patch that avoids printing the column type names >> in the context message thus no cache lookups have to be done in the >> error context callback. I think the column name is enough to know on >> which column the error occurred and if required it's type can be known >> by the user. This patch gets rid of printing local and remote type >> names in slot_store_error_callback and also >> logicalrep_typmap_gettypname because it's unnecessary. Thoughts?
I've now pushed this patch. I noted that once we drop logicalrep_typmap_gettypname, there's really nothing using the LogicalRepTypMap table at all, so I nuked that too. (We can always recover the code from the git archives if some reason to use it emerges.) Didn't look at 0002 yet. regards, tom lane