Hi all, While digging into some of the TAP tests, I have noticed that 002_pgbench_no_server.pl prints array pointers, like that: opts=-f no-such-file, stat=1, out=ARRAY(0x1374d7990), err=ARRAY(0x14028dc40), name=pgbench option error: no file# Running: pgbench -f no-such-file
I am a bit dubious that this information is useful when it comes to debugging because we have the name of the tests close by, so I would just remove those extra logs. If people prefer keeping this information around, we could fix the format with something like the attached, for example. Thoughts? -- Michael
diff --git a/src/bin/pgbench/t/002_pgbench_no_server.pl b/src/bin/pgbench/t/002_pgbench_no_server.pl
index 9023fac52d..a3608ae5fc 100644
--- a/src/bin/pgbench/t/002_pgbench_no_server.pl
+++ b/src/bin/pgbench/t/002_pgbench_no_server.pl
@@ -26,7 +26,10 @@ sub pgbench
local $Test::Builder::Level = $Test::Builder::Level + 1;
my ($opts, $stat, $out, $err, $name) = @_;
- print STDERR "opts=$opts, stat=$stat, out=$out, err=$err, name=$name";
+ print STDERR "opts=$opts, stat=$stat, " .
+ "out=" . join(' ', @{$out}) . ", " .
+ "err=" . join(' ', @{$err}) . ", " .
+ "name=$name\n";
command_checks_all([ 'pgbench', split(/\s+/, $opts) ],
$stat, $out, $err, $name);
return;
signature.asc
Description: PGP signature
