On Mon, Jun 21, 2021 at 3:16 PM vignesh C <vignes...@gmail.com> wrote:
> I felt this is ok as we specify the keycount to be 1, so only the > key[0] will be used. Thoughts? > ScanKeyInit(&key[0], > Anum_pg_class_relkind, > BTEqualStrategyNumber, F_CHAREQ, > CharGetDatum(RELKIND_PARTITIONED_TABLE)); > > scan = table_beginscan_catalog(classRel, 1, key); > It maybe fine, just doesn't look correct when you look at the function as a whole. > > ================================= > > > > in UpdatePublicationTypeTupleValue(): > > > > + tup = heap_modify_tuple(tup, RelationGetDescr(rel), values, nulls, > > + replaces); > > + > > + /* Update the catalog. */ > > + CatalogTupleUpdate(rel, &tup->t_self, tup); > > > > Not sure if this tup needs to be freed or if the memory context will > > take care of it. > > I felt this is ok, as the cleanup is handled in the caller function > "AlterPublication", thoughts? > /* Cleanup. */ > heap_freetuple(tup); > table_close(rel, RowExclusiveLock); that should be fine. regards, Ajin Cherian Fujitsu Australia
