Thomas Munro <thomas.mu...@gmail.com> writes:
> On Sat, Jun 19, 2021 at 5:07 PM Thomas Munro <thomas.mu...@gmail.com> wrote:
>> if (error != LLVMErrorSuccess)
>> LLVMOrcDisposeMaterializationUnit(mu);
>>
>> +#if LLVM_VERSION_MAJOR > 12
>> + for (int i = 0; i < LookupSetSize; i++)
>> + LLVMOrcRetainSymbolStringPoolEntry(symbols[i].Name);
>> +#endif
> (Though, erm, that code probably either needs to move a bit further up
> or become conditional, considering the error case immediately above
> it, not sure which...)
Is a compile-time conditional really going to be reliable? See nearby
arguments about compile-time vs run-time checks for libpq features.
It's not clear to me how tightly LLVM binds its headers and running
code.
regards, tom lane
