On Fri, Jun 18, 2021 at 9:18 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > I thought it was cheap enough to check that the relation we open is an > > index, because if it is not, we'll segfault when accessing fields of the > > relation->rd_index struct. I wouldn't necessarily advocate doing any > > really expensive checks here, but a quick sanity check seemed worth the > > effort. > > > > I am not telling you anything about the cost of these sanity checks. I > suggest you raise elog rather than return NULL because if this happens > there is definitely some problem and continuing won't be a good idea. >
Pushed, after making the above change. Additionally, I have moved the test case to the existing file 001_rep_changes instead of creating a new one as the test seems to fit there and I was not sure if the test for just this case deserves a new file. -- With Regards, Amit Kapila.
