On Friday, June 18, 2021 11:41 AM osumi.takami...@fujitsu.com <osumi.takami...@fujitsu.com> wrote: > On Thursday, June 17, 2021 10:34 PM Simon Riggs > <simon.ri...@enterprisedb.com> wrote: > > On Thu, Jun 17, 2021 at 12:57 PM Amit Kapila <amit.kapil...@gmail.com> > > wrote: > > > On Thu, Jun 17, 2021 at 4:27 PM Amit Kapila > > > <amit.kapil...@gmail.com> > > wrote: > > > > > > > > On Thu, Jun 17, 2021 at 8:41 AM osumi.takami...@fujitsu.com > > > > <osumi.takami...@fujitsu.com> wrote: > > > > > > > > Pushed! > > > > > > > [Responding to Simon's comments] > > > > > > > If LOCK and TRUNCATE is advised against on all user catalog > > > > tables, why would CLUSTER only apply to pg_class? Surely its > > > > locking level is the > > same as LOCK? > > > > > > > > > > Cluster will also apply to all user catalog tables. I think we can > > > extend it slightly as we have mentioned for Lock. > > > > OK, good. > > > > > > The use of "[user]" isn't fully explained, so it might not be > > > > clear that this applies to both Postgres catalog tables and any > > > > user tables that > > have been nominated as catalogs. Probably worth linking to the > "Capabilities" > > section to explain. > > > > > > > > > > Sounds reasonable. > Simon, I appreciate your suggestions and yes, if the user catalog table is > referenced by the output plugin, it can be another cause of the deadlock. > > I'm going to post the patch for the those two changes, accordingly. Hi, I've made the patch-set to cover the discussion above for all-supported versions. Please have a look at those.
Best Regards,
Takamichi Osumi
HEAD_extend_logical_decoding_caveats_in_sync_mode_v01.patch
Description: HEAD_extend_logical_decoding_caveats_in_sync_mode_v01.patch
PG10_extend_logical_decoding_caveats_in_sync_mode_v01.patch
Description: PG10_extend_logical_decoding_caveats_in_sync_mode_v01.patch
PG11_extend_logical_decoding_caveats_in_sync_mode_v01.patch
Description: PG11_extend_logical_decoding_caveats_in_sync_mode_v01.patch
PG12_extend_logical_decoding_caveats_in_sync_mode_v01.patch
Description: PG12_extend_logical_decoding_caveats_in_sync_mode_v01.patch
PG13_extend_logical_decoding_caveats_in_sync_mode_v01.patch
Description: PG13_extend_logical_decoding_caveats_in_sync_mode_v01.patch
PG96_extend_logical_decoding_caveats_in_sync_mode_v01.patch
Description: PG96_extend_logical_decoding_caveats_in_sync_mode_v01.patch
