On Thu, Jun 17, 2021 at 9:34 AM Tom Lane <t...@sss.pgh.pa.us> wrote: > I think putting a version number as such in there is a truly > horrid idea. However, I could get behind adding a boolean flag > that says specifically whether the pipeline feature exists. > Then you'd do something like > > #ifdef LIBPQ_HAS_PIPELINING > > rather than embedding knowledge of exactly which release > added that.
I realize that this kind of feature-based testing is generally considered a best practice, but the problem is we're unlikely to do it consistently. If we put a version number in there, people will be able to test for whatever they want. Then again, why would pg_config.h be absent? -- Robert Haas EDB: http://www.enterprisedb.com