On 6/15/21 1:52 PM, Tom Lane wrote: > Alvaro Herrera <alvhe...@alvh.no-ip.org> writes: >> On 2021-Jun-15, Tom Lane wrote: >>> I think this ought to be reverted and reviewed more carefully. >> It seems to me that removing the cast-to-range[] is a sufficient fix, >> and that we can do with only the unnest part for pg14; the casts can be >> added in 15 (if at all). That would mean reverting only half the patch. > Might be a reasonable solution. But right now I'm annoyed that the > buildfarm is broken, and I'm also convinced that this didn't get > adequate testing. I think "revert and reconsider" is the way > forward for today. > >
(RMT hat on) That would be my inclination at this stage. The commit message states that it's trivial, but it seems not to be, and I suspect it should not have been done at this stage of the development cycle. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
