Hi, Removing legitimate warnings can it be worth it?
-1 CAST can be wrong, when there is an invalid value defined (InvalidBucket, InvalidBlockNumber). I think depending on the compiler -1 CAST may be different from InvalidBucket or InvalidBlockNumber. pg_rewind is one special case. All cases of XLogSegNo (uint64) initialization are zero, but in pg_rewind was used -1? I did not find it InvalidXLogSegNo! Not tested. Trivial patch attached. best regards, Ranier Vilela
fix_signed_vs_unsigned.patch
Description: Binary data
