On Wed, Jun 9, 2021 at 9:57 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Wed, Jun 9, 2021 at 4:50 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > On Wed, Jun 9, 2021 at 1:53 AM Jeff Davis <pg...@j-davis.com> wrote: > > > > > > On Tue, 2021-06-08 at 17:41 +1000, Ajin Cherian wrote: > > > > Here's an updated patchset that adds back in the option for two-phase > > > > in CREATE_REPLICATION_SLOT command and a second patch that adds > > > > support for > > > > two-phase decoding in pg_recvlogical. > > > > > > A few things: > > > > > > * I suggest putting the TWO_PHASE keyword after the LOGICAL keyword > > > > > > > Isn't it better to add it after LOGICAL IDENT? In docs [1], we expect > > that way. Also, see code in libpqrcv_create_slot where we expect them > > to be together but we can change that if you still prefer to add it > > after LOGICAL. BTW, can't we consider it to be part of > > create_slot_opt_list?
Changed accordingly. > Some more points: > 1. pg_recvlogical can only send two_phase option if > (PQserverVersion(conn) >= 140000), otherwise, it won't work for older > versions of the server. Updated accordingly. I've also modified the pg_recvlogical test case with the new option. regards, Ajin Cherian
v4-0001-Add-option-to-set-two-phase-in-CREATE_REPLICATION.patch
Description: Binary data
v4-0002-Add-support-for-two-phase-decoding-in-pg_recvlogi.patch
Description: Binary data
