On Wed, Jun 9, 2021 at 1:37 PM Peter Eisentraut <peter.eisentr...@enterprisedb.com> wrote: > Can we scan all the test names first and then pick a suitable length?
FWIW, I think this discussion of shortening the test case names is probably going in the wrong direction. It's true that in many cases such a thing can be done, but it's also true that the test case authors picked those names because they felt that they described those test cases well. It's not unlikely that future test case authors will have similar feelings and will again pick names that are a little bit longer. It's also not impossible that in shortening the names we will make them less clear. For example, Peter said that "partition" was redundant in something like "detach-partition-concurrently-4," but that is only true if you think that a partition is the only thing that can be detached. That is true today as far as the SQL grammar is concerned, but from a source code perspective we speak of detaching from shm_mq objects or DSMs, and there could be more things, internal or SQL-visible, in the future. Now I don't care all that much; this isn't worth getting worked up about. But if it were me, I'd tend to err in the direction of accommodating longer test names, and only shorten them if it's clear that someone *really* went overboard. -- Robert Haas EDB: http://www.enterprisedb.com
