On Tuesday, June 8, 2021 7:30 PM David Rowley <dgrowle...@gmail.com> > On Tue, 8 Jun 2021 at 21:50, houzj.f...@fujitsu.com <houzj.f...@fujitsu.com> > wrote: > > I noticed that the first function parameter in > > get_qual_from_partbound(**Relation rel**, Relation parent, is not used in > > the > function. > > > > Is it better to remove it like the attached patch ? > > Going by [1] it was used when it went in. It looks like it was for mapping > attribute > numbers between parent and partition rels. > > Going by [2], it looks like it became unused due to the attribute mapping code > being moved down into map_partition_varattnos(). > > As for whether we should remove it or not, because it's an external function > that an extension might want to use, it would need to wait until at least we > branch for PG15. > > Likely it's best to add the patch to the July commitfest so that we can make a > decision then.
OK, Thanks for the explanation. Added to CF: https://commitfest.postgresql.org/33/3159/ Best regards, houzj
