On Fri, Jun  4, 2021 at 04:31:06PM -0500, Justin Pryzby wrote:
> doc/src/sgml/release-14.sgml-      <listitem>
> doc/src/sgml/release-14.sgml-<!--
> doc/src/sgml/release-14.sgml-Author: Fujii Masao <fu...@postgresql.org>
> doc/src/sgml/release-14.sgml-2020-10-02 [8d9a93596] Add pg_stat_wal 
> statistics view.
> doc/src/sgml/release-14.sgml-Author: Fujii Masao <fu...@postgresql.org>
> doc/src/sgml/release-14.sgml-2020-12-02 [01469241b] Track total number of WAL 
> records, FPIs and bytes genera
> doc/src/sgml/release-14.sgml-Author: Fujii Masao <fu...@postgresql.org>
> doc/src/sgml/release-14.sgml:2021-03-09 [ff99918c6] Track total amounts of 
> times spent writing and syncing W
> doc/src/sgml/release-14.sgml--->
> doc/src/sgml/release-14.sgml-
> doc/src/sgml/release-14.sgml-       <para>
> doc/src/sgml/release-14.sgml-        Add system view <link
> doc/src/sgml/release-14.sgml-        
> linkend="monitoring-pg-stat-wal-view"><structname>pg_stat_wal</structname></link>
> doc/src/sgml/release-14.sgml-        which reports <acronym>WAL</acronym> 
> activity (Masahiro Ikeda)
> doc/src/sgml/release-14.sgml-       </para>
> doc/src/sgml/release-14.sgml-      </listitem>
> 
> I think this should also mention the GUC:
> | track_wal_io_timing

This is part of this commit:

        commit ff99918c62
        Author: Fujii Masao <fu...@postgresql.org>
        Date:   Tue Mar 9 16:52:06 2021 +0900
        
            Track total amounts of times spent writing and syncing WAL data to 
disk.
        
            This commit adds new GUC track_wal_io_timing. When this is enabled,
            the total amounts of time XLogWrite writes and issue_xlog_fsync 
syncs
            WAL data to disk are counted in pg_stat_wal. This information would 
be
            useful to check how much WAL write and sync affect the performance.

The feature is clearly the new system view pg_stat_wal.  The question is
whether we should also document that track_wal_io_timing adds timing
control to that new system view.  Normally we don't mention additional
features, like pg_dump support, for features we add in a major release. 
The documentation we link to from the release notes does mention
track_wal_io_timing.

-- 
  Bruce Momjian  <br...@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.



Reply via email to