On Thu, Jun 03, 2021 at 02:36:15PM -0700, Jeff Davis wrote: > Do we have general agreement on this point? Did I miss another purpose > of detoasting in tablecmds.c, or can we just remove that part of the > patch?
Catching up with this thread.. So, what you are suggesting here is that we have no need to let ATRewriteTable() do anything about the detoasting, and just push down the responsability of detoasting the tuple, if necessary, down to the AM layer where the tuple insertion is handled, right? In short, a table AMs would receive on a rewrite with ALTER TABLE tuples which may be toasted, still table_insert_tuple() should be able to handle both: - the case where this tuple was already toasted. - the case where this tuple has been already detoasted. You are right that this would be more consistent with what heap does with heap_prepare_insert(). -- Michael
signature.asc
Description: PGP signature
