On Wed, Jun 2, 2021 at 7:20 PM Kuntal Ghosh <kuntalghosh.2...@gmail.com> wrote: > > On Wed, Jun 2, 2021 at 3:10 PM Dilip Kumar <dilipbal...@gmail.com> wrote: > > > > Yes, you are right. I will change it in the next version, along with > > the test case. > > > + /* > + * if the key hasn't changed and we're only logging the key, we're done. > + * But if tuple has external data then we might have to detoast the key. > + */ > This doesn't really mention why we need to detoast the key even when > the key remains the same. I guess we can add some more details here.
Noted, let's see what others have to say about fixing this, then I will fix this along with one other pending comment and I will also add the test case. Thanks for looking into this. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
